stillalex commented on PR #1854: URL: https://github.com/apache/solr/pull/1854#issuecomment-1686762490
> I disagree; both are "instrumentation" and the class name was already chosen in this generic way instead of being called MetricsBlahBlahBlah. Nonetheless the concerns could be split up to work in parallel but it's extra code for unclear gain. sure, I see the point and I don't disagree with it. > BTW again in my fork locally, I did similarly for the Jetty side in InstrumentedHttpListenerFactory moving the previous logic to this central location, and I think in so doing picked up more use-cases. is this code you mention open source? if so could you link to it? it would make the discussion much easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
