stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1301571072
########## solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java: ########## @@ -114,6 +115,26 @@ public void test() throws IOException, SolrServerException { } } + @Test + public void testApacheClient() throws Exception { + // call api that uses apache client impl Review Comment: sure I even mentioned this in my own PR comment > the test is fragile, as it assumes the api call will rely on apache http client impl, if this were to change in the future the test would not be useful anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org