gerlowskija opened a new pull request, #1867:
URL: https://github.com/apache/solr/pull/1867

   https://issues.apache.org/jira/browse/SOLR-16825
   
   
   # Description
   
   Request and response body POJOs in the 'api' module must implement 
'ReflectWritable', a marker interface that indicates to JavabinCodec and other 
serialization classes that they have field information that can be discovered 
via reflection.
   
   A prior commit added several POJOs to this module that didn't follow this 
rule, causing test failures in nightly runs.
   
   # Solution
   
   This commit adds the needed marker interface to several classes in the 'api' 
submodule that were missing it.
   
   # Tests
   
   Broken tests resume passing.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to