HoustonPutman commented on PR #1867: URL: https://github.com/apache/solr/pull/1867#issuecomment-1696147981
Ok we don't need to use `ReflectWritable` I think... Basically we can assume that any non-known class uses ReflectWritable... By changing: - `JavaBinCodec:276` -> `writeMap(new DelegateMapWriter(val));` - `TextWriter:114` -> `writeMap(name, new DelegateMapWriter(val));` I'm going to run the full test suite to make sure this works, but it would be very nice if it does. Also we can keep the `ReflectWriter` checks in the if-else statements, so that other types can be overriden to choose DelegateMapWriter instead of their default serialization method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
