HoustonPutman commented on code in PR #1867:
URL: https://github.com/apache/solr/pull/1867#discussion_r1308858864
##########
solr/solrj/src/java/org/apache/solr/common/util/TextWriter.java:
##########
@@ -88,7 +87,7 @@ default void writeVal(String name, Object val, boolean raw)
throws IOException {
} else if (val instanceof MapWriter) {
writeMap(name, (MapWriter) val);
} else if (val instanceof ReflectWritable) {
- writeMap(name, new DelegateMapWriter(val));
+ writeVal(name, Utils.getReflectWritable(val));
Review Comment:
Ok, the name is probably really bad here, but `getReflectWritable()` does
not return a `ReflectWritable` class. It returns that `DelegateReflectWriter`.
I'll rename this to `getReflectWriter()`, as it will be much less confusing.
Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
