epugh commented on code in PR #1923:
URL: https://github.com/apache/solr/pull/1923#discussion_r1325967518
##########
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##########
@@ -436,7 +439,10 @@ protected void runCloudExample(CommandLine cli) throws
Exception {
boolean prompt = !cli.hasOption("noprompt");
int numNodes = 2;
- int[] cloudPorts = new int[] {8983, 7574, 8984, 7575};
+ int defaultPort =
+ Integer.parseInt(
+ cli.getOptionValue('p',
SystemUtils.getEnvironmentVariable("SOLR_PORT", "8983")));
+ int[] cloudPorts = new int[] {defaultPort, defaultPort + 1, defaultPort +
2, defaultPort + 3};
Review Comment:
Yay! Finally have port numbers that make a bit more sense...
##########
solr/packaging/build.gradle:
##########
@@ -250,11 +251,18 @@ task integrationTests(type: BatsTask) {
// TODO - if quiet then don't tee
standardOutput = new TeeOutputStream(System.out, new
FileOutputStream("$integrationTestOutput/test-output.txt"))
-
+ println("Runnin BATS tests with Solr base port ${solrPort}")
Review Comment:
"Running"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
