janhoy commented on code in PR #1923: URL: https://github.com/apache/solr/pull/1923#discussion_r1325977019
########## solr/packaging/test/test_zz_cleanup.bats: ########## Review Comment: I'm wondering whether this test is even needed, if stop -all works properly. It asserts that no nodes are running. Fun fact. The `solr status` command checks SOLR_PID_DIR first, if nothing found it runs a `ps` command or something. While the `solr stop -all` script will only consult pid files, and give up if not found. That's why `solr status` will always find your running instances, where `stop -all` won't. Have not tried to fix that here, but should we? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
