risdenk commented on code in PR #1923:
URL: https://github.com/apache/solr/pull/1923#discussion_r1325989312


##########
solr/packaging/build.gradle:
##########
@@ -238,6 +238,7 @@ task integrationTests(type: BatsTask) {
   def integrationTestOutput = "$buildDir/test-output"
   def solrHome = "$integrationTestOutput/solr-home"
   def solrTestFailuresDir = "$integrationTestOutput/failure-snapshots"
+  def solrPort = new Random().nextInt(10000, 50000)

Review Comment:
   Future improvement idea: check that the ports chosen aren't actually in use 
by anything before the test(s). I like this improvement, but there is no 
guarantee that a run won't conflict with an already allocated port on the 
machine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to