janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334344311
########## solr/core/src/resources/EnvToSyspropMappings.properties: ########## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir SOLR_WAIT_FOR_ZK=waitForZk +ZK_CLIENT_TIMEOUT=zkClientTimeout +ZK_CREATE_CHROOT=createZkChroot +ZK_HOST=zkHost # These should not be mapped to system properties Review Comment: The ones I marked as no map are either SSL props that must anyway be set in script because they are read by Jetty (?), or variables that are temp variables in the script (SOLR_OPTS etc) that have no real use as sysProps, but are still exported since we export everything `SOLR_*` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
