janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334880267
########## solr/bin/solr: ########## @@ -112,6 +112,13 @@ elif [ -r "$SOLR_INCLUDE" ]; then . "$SOLR_INCLUDE" fi +# Export variables we want to make visible to Solr sub-process +for var in $(compgen -e); do + if [[ "$var" =~ ^(SOLR_.*|DEFAULT_CONFDIR|ZK_.*|GCS_BUCKET|GCS_.*|S3_.*|OTEL_.*|AWS_.*)$ ]]; then Review Comment: By exporting more patterns we make sure users can add such vars to `solr.in.sh` and still get them exported to solr app without prefixing with `export` in solr.in.sh. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
