HoustonPutman commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334448322
########## solr/core/src/resources/EnvToSyspropMappings.properties: ########## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir SOLR_WAIT_FOR_ZK=waitForZk +ZK_CLIENT_TIMEOUT=zkClientTimeout +ZK_CREATE_CHROOT=createZkChroot +ZK_HOST=zkHost # These should not be mapped to system properties Review Comment: The client SSL options (`SOLR_SSL_CLIENT_*`, `SOLR_SSL_CHECK_PEER_NAME`) are not read by the Jetty Server, they are read instead by the SolrClients. They should be mapped. You are missing `SOLR_SSL_CLIENT_HOSTNAME_VERIFICATION` for the non-mapped options. This is a server option, so it will be read by the jetty config on startup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
