HoustonPutman commented on PR #636: URL: https://github.com/apache/solr-operator/pull/636#issuecomment-1743747944
> > If the user doesn't provide solr.sharedLib, the xml section will start with ,. > > Hmm, not quite sure what you mean. Are you talking about the [GenerateAdditionalLibXMLPart change here](https://github.com/apache/solr-operator/pull/636/files#diff-653faf42eabedf3285e433f247c993282f035ee70781d151f8c8d68fee2621a3R858)? > > If so, AFAICT, 'libList' will never be empty because it at least always has `${solr.sharedLib:}`. So if the user doesn't use any backups or modules, the produced XML should look like: > > ``` > <str name="sharedLib">${solr.sharedLib:}</str> > ``` > > But, maybe I'm missing something @HoustonPutman ? So my thought was if `${solr.sharedLib:}` equates to an empty string, which it will by default, that Solr wouldn't handle the `,` in the beginning very well. But I just tested it out, and it works fine! So no issue there 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
