HoustonPutman commented on code in PR #636:
URL: https://github.com/apache/solr-operator/pull/636#discussion_r1344766826
##########
controllers/util/solr_util.go:
##########
@@ -134,7 +135,7 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.SolrCl
// Keep track of the SolrOpts that the Solr Operator needs to set
// These will be added to the SolrOpts given by the user.
- allSolrOpts := []string{"-DhostPort=$(SOLR_NODE_PORT)"}
Review Comment:
So we can actually just use an envVar, `SOLR_PORT_ADVERTISE`, instead of
relying on SOLR_OPTS. Makes the code a small bit cleaner 🙂
But we can keep the `hostPort` in place and deprecate it (So we would be
using `-DhostPort` and `SOLR_PORT_ADVERTISE` at the same time), to give people
with a custom `solr.xml` a release to change their Solr.xml to use
`solr.port.advertise`, like is used in the official `solr.xml`. As long as we
document it in the upgrade notes, we should be good to go!
##########
controllers/util/solr_util.go:
##########
@@ -134,7 +135,7 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.SolrCl
// Keep track of the SolrOpts that the Solr Operator needs to set
// These will be added to the SolrOpts given by the user.
- allSolrOpts := []string{"-DhostPort=$(SOLR_NODE_PORT)"}
Review Comment:
So we can actually just use an envVar, `SOLR_PORT_ADVERTISE`, instead of
relying on SOLR_OPTS. Makes the code a small bit cleaner 🙂
But we can keep the `hostPort` in place and deprecate it (So we would be
using `-DhostPort` and `SOLR_PORT_ADVERTISE` at the same time), to give people
with a custom `solr.xml` a release to change their Solr.xml to use
`solr.port.advertise`, like is used in the official `solr.xml`. As long as we
document it in the upgrade notes, we should be good to go!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
