gerlowskija commented on code in PR #636:
URL: https://github.com/apache/solr-operator/pull/636#discussion_r1345786066
##########
controllers/util/solr_util.go:
##########
@@ -134,7 +135,7 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.SolrCl
// Keep track of the SolrOpts that the Solr Operator needs to set
// These will be added to the SolrOpts given by the user.
- allSolrOpts := []string{"-DhostPort=$(SOLR_NODE_PORT)"}
Review Comment:
Ah, right! I forgot `bin/solr` was set up to convert `SOLR_PORT_ADVERTISE`
to a sysprop that solr.xml can take advantage of, cool. 👍
##########
controllers/util/solr_util.go:
##########
@@ -134,7 +135,7 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.SolrCl
// Keep track of the SolrOpts that the Solr Operator needs to set
// These will be added to the SolrOpts given by the user.
- allSolrOpts := []string{"-DhostPort=$(SOLR_NODE_PORT)"}
Review Comment:
Ah, right! I forgot `bin/solr` was set up to convert `SOLR_PORT_ADVERTISE`
to a sysprop that solr.xml can take advantage of, cool. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
