dsmiley commented on code in PR #2177:
URL: https://github.com/apache/solr/pull/2177#discussion_r1442510069
##########
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##########
@@ -175,6 +175,19 @@ public void setQueryParams(Set<String> queryParams) {
public abstract SolrParams getParams();
+ /**
+ * Determines whether this request should use or ignore any specified data
stores (esp. {@link
+ * SolrClient#defaultCollection})
+ *
+ * <p>Many Solr requests target a particular data store (i.e. core or
collection). But not all of
+ * them - many Solr APIs (e.g. security or other admin APIs) are agnostic of
data stores entirely.
+ * This method gives these requests a way to opt out of using {@link
SolrClient#defaultCollection}
+ * or other specified data stores.
+ */
+ public boolean requiresDataStore() {
Review Comment:
This is a search engine after all; we don't have to be overly generic with
this "data store" word.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
