gerlowskija commented on PR #2177: URL: https://github.com/apache/solr/pull/2177#issuecomment-1894215477
Another slightly less arcane example is the [DataStoreSolrRequest](https://github.com/apache/solr/pull/2177/files#diff-e13377598540e9ce1e314f17966d3f37cbe71433fe3ec6b91785751aa57df622) class added on this PR. "CollectionSolrRequest" or "CollectionRequiringSolrRequest" isn't totally unserviceable here, but I worry that some reader without the context of our discussion here might take these names to mean that these request classes can only be used with proper SolrCloud collections. Javadocs can solve this to some extent. But that feels a bit like putting a bucket under your sink instead of fixing the leak. If you know when you're writing a class that you'll need the Javadocs to clarify the potentially-misconstrue-able name, IMO you need a different name 😛 > How much do you hate the idea of not having storeType? I'm not especially attached to "store". I just think there are some places where it'd be helpful to have a term that's not "collection". I don't really care beyond *what* that term is, as long as I have *something* to use in those cases so I don't feel blocked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
