dsmiley commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1698602604
##########
solr/core/src/test/org/apache/solr/TestTimeAllowedSearch.java:
##########
@@ -0,0 +1,104 @@
+package org.apache.solr;
+
+import com.carrotsearch.randomizedtesting.generators.RandomStrings;
+import java.util.Calendar;
+import java.util.GregorianCalendar;
+import java.util.Locale;
+import java.util.TimeZone;
+import org.apache.solr.client.solrj.SolrQuery;
+import org.apache.solr.client.solrj.impl.CloudSolrClient;
+import org.apache.solr.client.solrj.request.CollectionAdminRequest;
+import org.apache.solr.client.solrj.request.UpdateRequest;
+import org.apache.solr.client.solrj.response.QueryResponse;
+import org.apache.solr.cloud.MiniSolrCloudCluster;
+import org.apache.solr.cloud.SolrCloudTestCase;
+import org.apache.solr.common.SolrInputDocument;
+import org.apache.solr.common.params.CommonParams;
+import org.apache.solr.common.params.ShardParams;
+
+public class TestTimeAllowedSearch extends SolrCloudTestCase {
+
+ /**
+ * This test demonstrates timeAllowed expectation at @{@link
+ * org.apache.solr.handler.component.HttpShardHandler} level This test
creates collection with
+ * 'implicit` router, which has two shards shard_1 has 100000 docs, so that
query should take some
+ * time shard_2 has only 1 doc to demonstrate the HttpSHardHandler timeout
Then it execute
+ * substring query with TIME_ALLOWED 50, assuming this query will time out
on shard_1
+ */
+ public void testTimeAllowed() throws Exception {
+ MiniSolrCloudCluster cluster =
+ configureCluster(2).addConfig("conf",
configset("cloud-minimal")).configure();
+ try {
+ CloudSolrClient client = cluster.getSolrClient();
+ String COLLECTION_NAME = "test_coll";
+ CollectionAdminRequest.createCollection(COLLECTION_NAME, "conf", 2, 1)
+ .setRouterName("implicit")
+ .setShards("shard_1,shard_2")
+ .process(cluster.getSolrClient());
+ cluster.waitForActiveCollection(COLLECTION_NAME, 2, 2);
+ UpdateRequest ur = new UpdateRequest();
+ for (int i = 0; i < 100000; i++) {
+ SolrInputDocument doc = new SolrInputDocument();
+ doc.addField("id", "" + i);
+ final String s =
+ RandomStrings.randomAsciiLettersOfLengthBetween(random(), 10, 100)
+ .toLowerCase(Locale.ROOT);
+ doc.setField("subject_s", s);
+ doc.setField("_route_", "shard_1");
+ ur.add(doc);
+ }
+
+ // adding "abc" in each shard as we will have query *abc*
+ SolrInputDocument doc = new SolrInputDocument();
+ doc.addField("id", "" + 10000);
+ doc.setField("subject_s", "abc");
+ doc.setField("_route_", "shard_2");
+ ur.add(doc);
+
+ doc = new SolrInputDocument();
+ doc.addField("id", "" + 100001);
+ doc.setField("subject_s", "abc");
+ doc.setField("_route_", "shard_1");
+ ur.add(doc);
+
+ ur.commit(client, COLLECTION_NAME);
+
+ // warm up query
+ SolrQuery query = new SolrQuery();
+ query.setQuery("subject_s:*abcd*");
+ query.set(ShardParams.SHARDS_TOLERANT, "true");
+ QueryResponse response = client.query(COLLECTION_NAME, query);
+
+ query = new SolrQuery();
+ query.setQuery("subject_s:*abc*");
+ query.set(CommonParams.TIME_ALLOWED, 40);
+ query.set(ShardParams.SHARDS_TOLERANT, "true");
+ response = client.query(COLLECTION_NAME, query);
+ assertTrue(
+ "Should have found 1 doc (shard_2) as timeallowed is 25ms found:"
Review Comment:
There is also DelaySearchComponent, which predated the more recent
org.apache.solr.search.ExpensiveSearchComponent (which I've never heard of).
The Expensive one looks cool -- it appears it might be used to affect one shard
but not another if no docs are returned from one shard. An advantage of
sleep() is that you don't need to modify the configset (to incorporate one of
these components) to call it :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
