mkhludnev commented on code in PR #2493: URL: https://github.com/apache/solr/pull/2493#discussion_r1730916305
########## solr/core/src/test/org/apache/solr/TestTimeAllowedSearch.java: ########## Review Comment: fyi here is an easier approach for testing time limits https://github.com/apache/solr/blob/7ef2c0ef36601d8ce8c83192738376ed7c2429ac/solr/core/src/test/org/apache/solr/cloud/CloudExitableDirectoryReaderTest.java#L286 It injects counter instead of wall clocks; then it finds number of ticks enough for a certain query; then it dissects max_count reproducing timeout and check error handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
