psalagnac commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1704360932
##########
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java:
##########
@@ -211,23 +216,33 @@ public ShardResponse takeCompletedIncludingErrors() {
*/
@Override
public ShardResponse takeCompletedOrError() {
- return take(true);
+ return take(true, -1);
}
- private ShardResponse take(boolean bailOnError) {
+ private ShardResponse take(boolean bailOnError, long maxAllowedTimeInMillis)
{
try {
- while (pending.get() > 0) {
- ShardResponse rsp = responses.take();
- responseFutureMap.remove(rsp);
Review Comment:
Following the change, we don't remove anymore completed requests from
`responseFutureMap`. My understanding is this line should be restored,
otherwise there `cancel()` method will consider the completed sub-requests too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
