timatbw commented on code in PR #2631:
URL: https://github.com/apache/solr/pull/2631#discussion_r1711363724
##########
solr/core/src/java/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactory.java:
##########
@@ -224,6 +224,17 @@ boolean doesDocumentExist(BytesRef indexedDocId) throws
IOException {
}
}
+ boolean doesChildDocumentExist(AddUpdateCommand cmd) throws IOException {
Review Comment:
I can, although they are effectively private helper methods for internal use
by this class, nobody should be calling them from outside. The only reason
they're not marked `private` is so I can refer to them in the unit tests.
Does Solr typically put javadoc on non-public methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
