epugh commented on code in PR #2631:
URL: https://github.com/apache/solr/pull/2631#discussion_r1711374955
##########
solr/core/src/java/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactory.java:
##########
@@ -224,6 +224,17 @@ boolean doesDocumentExist(BytesRef indexedDocId) throws
IOException {
}
}
+ boolean doesChildDocumentExist(AddUpdateCommand cmd) throws IOException {
Review Comment:
hummm... not sure on the non public! However, one thing is, I think we
have some sort of annotation "VisiblityForTesting" that we I think prefer...
I didn't see the `private` so thought it was public.... Maybe @dsmiley can
weigh in on your question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
