dsmiley commented on code in PR #2689:
URL: https://github.com/apache/solr/pull/2689#discussion_r1750643762
##########
solr/core/src/test/org/apache/solr/core/TestCoreContainer.java:
##########
@@ -1131,6 +1132,48 @@ public void testCoreInitFailuresOnReload() throws
Exception {
cc.shutdown();
}
+ public void testCustomSocketTimeoutForDefaultHttpClient() throws Exception {
Review Comment:
I could see _learning_ from TestCoreContainer but putting your test there
just to do something that could be done elsewhere doesn't seem like a good
reason to put the test there. Granted I'm also not sure where a good place for
this is either :-). So maybe here.
Must this thing be configured in solr.xml; can't we rely simply on EnvUtils
? I have a wish-list JIRA issue to unify things in a more automatic way. But
in the mean time, I recommend preferring EnvUtils over solr.xml for simple (not
structural / flexible) configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
