[
https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881058#comment-17881058
]
David Smiley commented on SOLR-17256:
-------------------------------------
>From the description:
bq. But moreover I think there's a conceptual discordance of placing this
concept on SolrRequest given that some clients want to route requests to nodes
they choose.
CloudSolrClient & LBSolrClient. It's not a deal breaker... we could say
LBSolrClient is internal so nobody use it please. CloudSolrClient, we could
allow the caller in the request to choose instead of CSC finding the right
node. It would then somehow have to skip LBSolrClient. Not sure how much work
this is. Nonetheless need to somehow change LBSolrClient so that it stops
mutating the request. Our clients shouldn't modify the requests!
Furthermore the EmbeddedSolrServer can't even handle it. Could throw
Unsupported, okay :-|
So this is why I'm thinking a special request method.
bq. Didn't we have a builder for SolrRequest earlier?
No.
> Remove SolrRequest.getBasePath setBasePath
> ------------------------------------------
>
> Key: SOLR-17256
> URL: https://issues.apache.org/jira/browse/SOLR-17256
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Reporter: David Smiley
> Priority: Minor
> Labels: newdev
> Time Spent: 20m
> Remaining Estimate: 0h
>
> SolrRequest has a getBasePath & setBasePath. The naming is poor; it's the
> URL base to the Solr node like "http://localhost:8983/solr";. It's only
> recognized by HttpSolrClient; LBSolrClient (used by CloudSolrClient) ignores
> it and will in fact mutate the passed in request to its liking, which is
> rather ugly because it means a request cannot be used concurrently if the
> user wants to. But moreover I think there's a conceptual discordance of
> placing this concept on SolrRequest given that some clients want to route
> requests to nodes *they* choose. I propose removing this from SolrRequest
> and instead adding a method specific to HttpSolrClient. Almost all existing
> usages of setBasePath immediately execute the request on an HttpSolrClient,
> so should be easy to change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
