[ 
https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882373#comment-17882373
 ] 

Jason Gerlowski commented on SOLR-17256:
----------------------------------------

I actually played with that approach initially, but couldn't get it to work 
quite right.  I had a "URLReplacingSolrClient" implementation that wrapped an 
existing client and tried to effect the alternate URL by overriding a 
"getBaseUrl()" method.  But the method-override wasn't having the intended 
effect because it was on the "surrounding" client, and not the inner "wrapped" 
one. I'm sure someone could figure out a way forward for that approach, but I 
couldn't in the few hours I spent on it.  Code 
[here|https://github.com/gerlowskija/solr/commits/SOLR-17256-replace-setBasePath-usage/]
 if anyone's curious to pick it up.

> Remove SolrRequest.getBasePath setBasePath
> ------------------------------------------
>
>                 Key: SOLR-17256
>                 URL: https://issues.apache.org/jira/browse/SOLR-17256
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>            Reporter: David Smiley
>            Priority: Minor
>              Labels: newdev, pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> SolrRequest has a getBasePath & setBasePath.  The naming is poor; it's the 
> URL base to the Solr node like "http://localhost:8983/solr";.  It's only 
> recognized by HttpSolrClient; LBSolrClient (used by CloudSolrClient) ignores 
> it and will in fact mutate the passed in request to its liking, which is 
> rather ugly because it means a request cannot be used concurrently if the 
> user wants to.  But moreover I think there's a conceptual discordance of 
> placing this concept on SolrRequest given that some clients want to route 
> requests to nodes *they* choose.  I propose removing this from SolrRequest 
> and instead adding a method specific to HttpSolrClient.  Almost all existing 
> usages of setBasePath immediately execute the request on an HttpSolrClient, 
> so should be easy to change.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to