timatbw commented on PR #2742: URL: https://github.com/apache/solr/pull/2742#issuecomment-2471097616
Yes that sounds good, as I feel we might be trying to expand the scope of this change too much for 1 PR. I agree, making the public modifiers change is needed, then we can document how to do a typical simple use-case of a custom aggregate in plugin code using only String values from json. That's enough for this PR. I'll work on that next, although I don't know much about the RefGuide as I've not written for it before, will look. And yes, next steps of work for another PR would be to add another method to ValueSourceParser and call it from FacetParser, so we fully support parent facets and non-String complex json config. I can produce a 2nd PR with my proposed diff for that change. And further steps are your Plan B, with complete ability to override or replace the FacetModule mechanism, and define new kinds of faceting totally different to the Facet Field/Range/Query etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
