dsmiley commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1933308834
##########
solr/solrj/build.gradle:
##########
@@ -48,7 +48,6 @@ dependencies {
})
implementation libs.apache.httpcomponents.httpclient
implementation libs.apache.httpcomponents.httpcore
- implementation libs.apache.commons.lang3
Review Comment:
weird; what's that doing in this PR?
##########
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##########
@@ -146,43 +126,21 @@ public T remove(final Object key) {
return super.remove((String) key);
}
- /**
- * Copies all of the mappings from the specified map to this map. These
mappings will replace any
- * mappings that this map had for any of the keys currently in the specified
map.
- *
- * @param m mappings to be stored in this map
- * @throws NullPointerException if the specified map is null
- */
@Override
public void putAll(final Map<? extends String, ? extends T> m) {
m.forEach(this::put);
Review Comment:
if you look at NamedList's shallow Map putAll impl, there's a faster
implementation if the map is empty at the start. We could incorporate that
here with a simple check that calls `this::add`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
