renatoh commented on PR #3048: URL: https://github.com/apache/solr/pull/3048#issuecomment-2622942999
> have a slight concern if there's existing code relying on quirky sad behaviors of NamedList.asShallowMap having weird/sad implementations of `keySet`, `values`, `entrySet` because it calls `asMap(1)` on them. Had it been `asMap(0)`, probably lower/no concern. _Maybe_ this change should be in Solr 10 only. On the other hand... maybe it's an unlikely impact? Hard to say... right away I see SolrXmlConfig calling `.asShallowMap().entrySet()`. Isn't SolrXmlConfig always calling .asShallowMap on a NamedList, which is create org.apache.solr.common.ConfigNode#forEachChild? So the changes do not make a difference here, or do they? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
