gus-asf commented on code in PR #2960:
URL: https://github.com/apache/solr/pull/2960#discussion_r1935817655
##########
solr/core/src/java/org/apache/solr/search/QueryResult.java:
##########
@@ -22,6 +22,7 @@ public class QueryResult {
// Object for back compatibility so that we render true not "true" in json
private Object partialResults;
private Boolean segmentTerminatedEarly;
Review Comment:
I agree it's good to know why so that the corrective action is clear, but
terminateEarly is unlike maxHits (or shardMaxHits) so the relationship takes
special knowledge to appreciate. If something is going to report a reason I'd
want it to include the same phrase... i.e. "maxHitsReached" and definately
would not want to have to "just know" that terminateEarly has nothing to do
with segmentTerminateEarly despite strong similarity in naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
