renatoh commented on code in PR #3163:
URL: https://github.com/apache/solr/pull/3163#discussion_r1947903626
##########
solr/solrj/src/test/org/apache/solr/common/util/TestJavaBinCodec.java:
##########
@@ -293,7 +306,7 @@ public void testForwardCompat() throws IOException {
for (int i = 1;
i < currentFormatBytes.length;
i++) { // ignore the first byte. It is version information
- assertEquals(newFormatBytes[i], currentFormatBytes[i]);
+ assertEquals("for i:" + i, newFormatBytes[i], currentFormatBytes[i]);
Review Comment:
@dsmiley
We have now 9 failing test, here my findings:
TestFastJavabinDecoder
testSimple-> the assert on line 136 fails due to the JSON with a SOM in it
has some extra line breaks
TestUpdateRequestCodec
testBackCompat4_5() -> failing because /solrj/updateReq_4_5.bin" has a Map
with SolrInputDocument as Key
testStreamableInputDocFormat -> because in
JavaBinUpdateRequestCodec.StreamingCodec#readOuterMostDocIterator line 315
instanceOf NamedList is now true, and it is checked before instanceof Map
ClusterStateProviderTest
6 tests are failing e.g. testClusterStateProvider -> assertThat on line
262 fails. ClusterState is using org.apache.solr.common.util.Utils to
deserialize the Json, which creates a LinkedHashMap and clusterStateHttp has
now a SOM in it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
