dsmiley commented on code in PR #3163:
URL: https://github.com/apache/solr/pull/3163#discussion_r1947912403
##########
solr/solrj/src/test/org/apache/solr/common/util/TestJavaBinCodec.java:
##########
@@ -293,7 +306,7 @@ public void testForwardCompat() throws IOException {
for (int i = 1;
i < currentFormatBytes.length;
i++) { // ignore the first byte. It is version information
- assertEquals(newFormatBytes[i], currentFormatBytes[i]);
+ assertEquals("for i:" + i, newFormatBytes[i], currentFormatBytes[i]);
Review Comment:
TestUpdateRequestCodec: dunno what to make of that without debugging;
hopefully you can make recommendations. Not surprised to see this _kind of
issue_ where some code is doing instanceof checks in a certain order, written
at a time when no NamedList was a Map but now a prominent (and even most
popular, I'd say) is actually one. You might want to search the codebase for
instanceof checks against NamedList to see if there are other areas to improve.
I have some WIP for Utils.java
ClusterStateProviderTest: looks like just needs to convert both maps to the
same type (e.g. wrap in HashMap) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
