dsmiley commented on PR #3208: URL: https://github.com/apache/solr/pull/3208#issuecomment-2684074527
I would _prefer_ we initialize the httpClients with security as soon as possible, before they are obtained, even if the design seems to support dynamic changes after creation. It'd be better to guarantee the initialization has happened. But it seems to awkward to guarantee that right now. On my mind is dependency-injection frameworks which can manage complex object graphs with dependencies for startup initialization. Any way that's kind of a fantasy right now, and a big undertaking to embrace that. I thought of a really simple solution here. I'm skeptical that ZkController.getSolrCloudManager truly *needs* to create yet another Http2SolrClient instance. It could use `getCoreContainer().getDefaultHttpSolrClient();` (coming from HttpSolrClientProvider, which is instrumented with security, albeit later but that's okay). If we want to mess with timeout tuning then I think that should be HttpSolrClientProvider instance to consider that (which is configurable!) and have it be more global. getSolrCloudManager isn't special. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
