HoustonPutman commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1981736330
##########
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##########
@@ -305,7 +305,7 @@ protected void runExample(CommandLine cli, String
exampleName) throws Exception
"techproducts".equals(exampleName) ? "sample_techproducts_configs" :
"_default";
boolean isCloudMode = !cli.hasOption(USER_MANAGED_OPTION);
- String zkHost = cli.getOptionValue(CommonCLIOptions.ZK_HOST_OPTION);
+ String zkHost = CLIUtils.getZkHostFromCliOrEnv(cli);
Review Comment:
I'm not sure it's too risky, since it's unlikely that it's going to do
anything that the user can't undo later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
