epugh commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1981755145
##########
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##########
@@ -216,12 +216,29 @@ public static String normalizeSolrUrl(CommandLine cli)
throws Exception {
}
/**
- * Get the ZooKeeper connection string from either the zk-host command-line
option or by looking
- * it up from a running Solr instance based on the solr-url option.
+ * Get the ZooKeeper connection string from either the zk-host command-line
option or if not
+ * configured, from the 'zkHost' system property aka the 'ZK_HOST'
environment variable.
+ *
+ * @param cli the command line
+ * @return the ZooKeeper connection string or null if not configured
+ */
+ public static String getZkHostFromCliOrEnv(CommandLine cli) {
Review Comment:
Could we look more closely at how CLIUtils. getDefaultSolrUrl works? It
feels like we need to make the looking up of ZK and Solr URL more aligned. Use
similiar names for the methods and similar patterns for the look ups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
