epugh commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1981763825
##########
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##########
@@ -305,7 +305,7 @@ protected void runExample(CommandLine cli, String
exampleName) throws Exception
"techproducts".equals(exampleName) ? "sample_techproducts_configs" :
"_default";
boolean isCloudMode = !cli.hasOption(USER_MANAGED_OPTION);
- String zkHost = cli.getOptionValue(CommonCLIOptions.ZK_HOST_OPTION);
+ String zkHost = CLIUtils.getZkHostFromCliOrEnv(cli);
Review Comment:
I can't reallyu imagine anyone running the example who wants it from
ZK_HOST. That would be a surprise. You know, I think there is a legit
argument that the RunExampleTool should NOT take in a ZKHost parameter. We
don't need the RunExampleTool to do everything that `bin/solr start` does.. We
need it to be really good at running an example solr. So, if we wanted to
eliminate standalone support from the RunExampleTool, I would get that. If we
wanted it to only do certain other things, I would get that too. One big
annonycance in the `bin/solr` script is all the special handling we have for
just running an example, and maybe if we narrow down what an example does, we
would have less special case code?
There are 14 options we pass to the run example!!!!!! And honestly, the
only option I ever pass is "techproducts" and "films" and "schemaless", every
other option could potentially be hard coded. Which would simpilify that
tool a LOT. It's an example tool, not a "let me debug solr in thwierd
configuration" tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
