dsmiley commented on code in PR #3263:
URL: https://github.com/apache/solr/pull/3263#discussion_r1994581560
##########
solr/core/src/test/org/apache/solr/cli/SolrCLIZkToolsTest.java:
##########
@@ -265,7 +275,10 @@ public void testCp() throws Exception {
new String[] {
"--zk-host",
zkAddr,
- "file:" + srcPathCheck.normalize().toAbsolutePath() + File.separator
+ "solrconfig.xml",
+ "file:"
+ + srcPathCheck.normalize().toAbsolutePath()
+ + FileSystems.getDefault().getSeparator()
Review Comment:
shouldn't we use resolve instead? And everywhere else in this source file
probably.
##########
solr/core/src/test/org/apache/solr/cli/SolrCLIZkToolsTest.java:
##########
@@ -417,7 +434,7 @@ public void testCp() throws Exception {
res = cpTool.runTool(SolrCLI.processCommandLineArgs(cpTool, args));
assertEquals("Copy should have succeeded.", 0, res);
- Path locEmpty = Paths.get(tmp2.toAbsolutePath().toString(), "stopwords",
"emptyfile");
+ Path locEmpty = Path.of(tmp2.toAbsolutePath().toString(), "stopwords",
"emptyfile");
Review Comment:
Use resolve here instead? and in many other places similarly
##########
solr/core/src/test/org/apache/solr/cli/SolrCLIZkToolsTest.java:
##########
@@ -279,12 +292,16 @@ public void testCp() throws Exception {
// src and cp3 are valid
String localNamed =
- tmp.normalize() + File.separator + "localnamed" + File.separator +
"renamed.txt";
+ tmp.normalize()
Review Comment:
shouldn't we use resolve() instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
