mlbiscoc commented on code in PR #3263:
URL: https://github.com/apache/solr/pull/3263#discussion_r2002068557
##########
solr/core/src/test/org/apache/solr/cli/SolrCLIZkToolsTest.java:
##########
@@ -131,12 +134,11 @@ public void testDownconfig() throws Exception {
ConfigSetDownloadTool downTool = new ConfigSetDownloadTool();
int res = downTool.runTool(SolrCLI.processCommandLineArgs(downTool, args));
assertEquals("Download should have succeeded.", 0, res);
- verifyZkLocalPathsMatch(
- Paths.get(tmp.toAbsolutePath().toString(), "conf"),
"/configs/downconfig1");
+ verifyZkLocalPathsMatch(tmp.toAbsolutePath().resolve("conf"),
"/configs/downconfig1");
Review Comment:
Ha after taking a look (almost) every `.toAbsolutePath()` is unnecessary
with an exception of I think a few and I am sure there is more. Made those
changes in
[7d02c14](https://github.com/apache/solr/pull/3263/commits/7d02c14d81098338744f449e1fd3b66733c9d603)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
