dsmiley commented on code in PR #3263:
URL: https://github.com/apache/solr/pull/3263#discussion_r2001745157
##########
solr/core/src/test/org/apache/solr/schema/TestSchemalessBufferedUpdates.java:
##########
@@ -57,19 +59,17 @@ public class TestSchemalessBufferedUpdates extends
SolrTestCaseJ4 {
@BeforeClass
public static void beforeClass() throws Exception {
- File tmpSolrHome = createTempDir().toFile();
- File tmpConfDir = new File(tmpSolrHome, confDir);
- File testHomeConfDir = new File(TEST_HOME(), confDir);
- FileUtils.copyFileToDirectory(
- new File(testHomeConfDir, "solrconfig-schemaless.xml"), tmpConfDir);
- FileUtils.copyFileToDirectory(
- new File(testHomeConfDir,
"schema-add-schema-fields-update-processor.xml"), tmpConfDir);
- FileUtils.copyFileToDirectory(
- new File(testHomeConfDir, "solrconfig.snippet.randomindexconfig.xml"),
tmpConfDir);
+ Path tmpSolrHome = createTempDir();
+ Path tmpConfDir = FilterPath.unwrap(tmpSolrHome.resolve(confDir));
Review Comment:
What's this change about? I've never heard of FilterPath before, which you
added to this test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
