dsmiley commented on code in PR #3326:
URL: https://github.com/apache/solr/pull/3326#discussion_r2041364372
##########
solr/solrj/src/resources/java-template/api.mustache:
##########
@@ -205,26 +203,23 @@ public class {{classname}} {
@Override
@SuppressWarnings("unchecked")
- public RequestWriter.ContentWriter getContentWriter(String
expectedType) {
+ public RequestWriter.ContentWriter getContentWriter(String
_expectedTypeIGNORE) {
Review Comment:
`getContentWriter` is passed an "expectedType" from the
`SolrClient.requestWriter` which defaults to "javabin". But V2 should ignore
that requestWriter as it's opinionated on how to write -- only supports JSON
via Jackson or raw writing. Perhaps that field in SolrClient should be named
`defaultRequestWriter`... although we're not choosing a different RequestWriter
so.... :shrug:
##########
solr/solrj/src/resources/java-template/api.mustache:
##########
@@ -133,7 +133,6 @@ public class {{classname}} {
{{#isBodyParam}}
{{#vendorExtensions.x-genericEntity}}
this.requestBody = requestBody;
- addHeader("Content-type", "application/json");
Review Comment:
This doesn't belong here. It's the ContentWriter that's responsible for the
type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
