gerlowskija commented on code in PR #3326:
URL: https://github.com/apache/solr/pull/3326#discussion_r2048771074
##########
solr/solrj/src/resources/java-template/api.mustache:
##########
@@ -133,7 +133,6 @@ public class {{classname}} {
{{#isBodyParam}}
{{#vendorExtensions.x-genericEntity}}
this.requestBody = requestBody;
- addHeader("Content-type", "application/json");
Review Comment:
I do like that better from an abstraction perspective, but I remember
putting this line here only after noticing that relying on the ContentWriter
was leaving the header unset in some cases. I wish I remembered the context
there better.
But let's not worry about that now - if it crops up again I'll reinvestigate
at that point...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
