gerlowskija commented on code in PR #3326:
URL: https://github.com/apache/solr/pull/3326#discussion_r2048779297
##########
solr/solrj/src/resources/java-template/api.mustache:
##########
@@ -205,26 +203,23 @@ public class {{classname}} {
@Override
@SuppressWarnings("unchecked")
- public RequestWriter.ContentWriter getContentWriter(String
expectedType) {
+ public RequestWriter.ContentWriter getContentWriter(String
_expectedTypeIGNORE) {
Review Comment:
[0] Maybe some version of this rationale should live as a comment in the
code/template, so that we can notice when those preconditions/assumptions
change?
e.g.
> // v2 currently only supports reading JSON request-bodies, so we ignore
the expected type suggestion provided by callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
