patsonluk commented on PR #2913: URL: https://github.com/apache/solr/pull/2913#issuecomment-2827217553
> @patsonluk do you know about this? **If** there's a problem, it's HttpShardHandler (the only caller) who passes this cloudDescriptor on to `org.apache.solr.handler.component.HttpShardHandler#canShortCircuit` which we want to return false for any coordinator. Maybe it will do so _anyway_. If we want to guarantee it, we could modify this code to recognize the coordinator somehow. So sorry @dsmiley ! I did not see the notification until now 😞 . Unfortunately, I don't know much about this neither. However, based on the code flow the removal should be fine as the existing method body of `getCloudDescriptor#getCloudDescriptor` is essentially the same as your [change](https://github.com/apache/solr/pull/2913/files#diff-ce2580113ae9a9d50f308985229130f094868e83d35a8727c5683e6a2f3f44daR376) ? Removing redundant method is always a nice thing to do 😊 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
