dsmiley commented on PR #2913: URL: https://github.com/apache/solr/pull/2913#issuecomment-2827800625
The canShortCircuit method simply wouldn't return true for the CloudDescriptor of a coordinator core because, for one, the collection name is different. And the shard id is null for another reason. But I've become more sympathetic to this getCloudDescriptor's existence. If it were to be removed, how then would some plugin/component from the handler on down (say a query parser or many other things) even know what it's collection even is? The standard way won't work in coordinator mode. But how is a plugin writer (developer or LLM nowadays LOL) to know? What's missing is documentation on `CoreDescriptor#getCloudDescriptor` to warn when *not* to call it, and to recommend `SolrQueryRequest.getCloudDescriptor` instead. Sadly, when this method was added, only one spot was changed to use the request when there are other spots that should. I see other places that should change: RealTimeGetComponent, ShardAugmenterFactory, AtomicUpdateDocumentMerger, DistributedZkUpdateProcessor, ... and more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
