patsonluk commented on PR #2913: URL: https://github.com/apache/solr/pull/2913#issuecomment-2830160309
@dsmiley Ah thanks for pointing that out, I have totally missed that! I totally hear your concern, the "special knowledge" makes it error prone for other dev (and i don't even remember that given that I did work with Coordinator logic on and off 😓 ). In theory we could override the `getCore` method in the anonymous `DelegatingSolrQueryRequest` within `wrappedReq` instead of `getCloudDescriptor`, but that would mean a new "wrapped" `SolrCore` with `getCloudDescriptor` overridden. However, that a wrapped SolrCore could mean a lot of boilerplate code (and some extra maintenance). Not sure which option is better 🤷🏼 We could improve the documentation as you suggested 😊 , it's not super intuitive tho (most dev probably don't even know what a synthetic/coordinator core is for) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
