janhoy commented on code in PR #3312:
URL: https://github.com/apache/solr/pull/3312#discussion_r2135688338
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -1766,7 +1766,7 @@ private SolrCore createFromDescriptor(
// this mostly happens when the core is deleted when this node is down
// but it can also happen if connecting to the wrong zookeeper
final boolean deleteUnknownCores =
- Boolean.parseBoolean(System.getProperty("solr.deleteUnknownCores",
"false"));
+
Boolean.parseBoolean(System.getProperty("solr.delete.unknown.cores", "false"));
Review Comment:
I can see that this is a painfully long prop, and I kind of agree with
Smiley that `solr.cloud.startup.deleteUnknownCores` would be a better choice.
But allowing CamelCase breaks the simple translation rule that you can take an
env.var and lowercase it and replace underscores with dots to get the sysprop.
Perhaps we could introduce dashes like
`SOLR_CLOUD_STARTUP_DELETE-UNKNOWN-CORES` but it soon gets to complex. Naming
has been and is a hard thing.
I'm personally willing to embrace structure and simplified rules for
parsing/mapping and sacrifice some readability or brewity. Perhaps further down
the road we could build one very simple config parser that instantiates config
objects without all the bolier-plate parsing code we have today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
