kotman12 commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2145278340
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##########
@@ -25,6 +25,12 @@
public abstract class HttpSolrClientBuilderBase<
B extends HttpSolrClientBuilderBase<?, ?>, C extends HttpSolrClientBase> {
+ /**
+ * About 24 days in milliseconds -- basically forever to wait for something.
But not so large to
+ * cause overflow.
+ */
+ protected static final long FOREVER_MILLIS = Integer.MAX_VALUE;
Review Comment:
I think it would be useful to expose this in some way. Either by making this
public or having a function in the builder which does this for you, i.e.:
```
public B withNoIdleTimeout() {
this.idleTimeoutMillis = FOREVER_MILLIS;
return (B) this;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
