HoustonPutman commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2159603675
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -129,6 +128,20 @@ protected Http2SolrClient(String serverBaseUrl, Builder
builder) {
super(serverBaseUrl, builder);
if (builder.httpClient != null) {
+ // Validate that no conflicting options are provided when using an
existing HttpClient
+ if (builder.followRedirects != null
+ || builder.connectionTimeoutMillis != null
+ || builder.maxConnectionsPerHost != null
+ || builder.useHttp1_1
Review Comment:
(Posting on the PR instead of the commit)
`useHttp1_1` behaves differently than the rest of these, because it is not a
default as Null option. So if someone wants to customize `useHttp1`, while not
changing the sysProp, this will fail.
I'll make a PR so that `useHttp1_1` is a Boolean and defaults to null, like
the rest of these.
(This was breaking some of the benchmark suites)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
