mlbiscoc commented on PR #3384: URL: https://github.com/apache/solr/pull/3384#issuecomment-2977881603
Actually the more I work on this, I think I am going to go with the path of renaming `SolrMetricsContext` to `SolrMetricsScope`. For `otel_scope_name`, we should update scope based on how the [OTEL instrumentation scope spec](https://opentelemetry.io/docs/specs/otel/common/instrumentation-scope/) recommends > Developers can decide what denotes a reasonable instrumentation scope. For example, they can select a module, a package, or a class as the instrumentation scope. So for `requestHandlerBase`, the `scopeName` in `SolrMetricsScope` should maybe be the package name of `org.apache.solr.handler`. If we really want to keep registries, then we can add a label called registry but I don't know if on an attribute based framework we still need the registry tag? Core metrics for example already have the `core` name as a label making it unique. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
