dsmiley commented on PR #3384: URL: https://github.com/apache/solr/pull/3384#issuecomment-2981828661
We don't need an attribute for the registry so long as our metrics are reasonably differentiated / clear. We can change our mind in the future with basically no disturbance, I suppose. I wouldn't get rid of SolrMetricsContext _yet_. AB also kind of recommended keeping it to reduce the review/impact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
