dsmiley commented on PR #3384: URL: https://github.com/apache/solr/pull/3384#issuecomment-2978617096
"Context" and "Scope" are almost synonymous... "Context" just potentially holds more than a scope. I'm not sure a rename is warranted; let's table that. Better to do big renames at the end to make the change easier to review beforehand, then any wrote renames that we think are warranted. Perhaps in a completely separate PR/commit. I read about [instrumentation scope](https://opentelemetry.io/docs/specs/otel/common/instrumentation-scope/); thanks. My overall sense reading it is that it's _not_ for how you propose to use it. Although, the last example given is "Internal application components emitting their own telemetry, relying on InstrumentationScope attributes to differentiate themselves in case multiple instances of the same type exist.". Which might mean how you are using it, or I suspect more likely it was thinking a big multi-versioned isolated system capable of running different versions of a component. Shrug. As I look at the code internally, I _do_ think this scope is structurally set up to be used as we want. Maybe we could identify another system using OTEL metrics, some DB-like system, and follow in their footsteps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
