bruno-roustant commented on code in PR #3412:
URL: https://github.com/apache/solr/pull/3412#discussion_r2175394674
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -2573,19 +2575,6 @@ public boolean checkTragicException(SolrCore solrCore) {
// failed to open an indexWriter
tragicException = e;
}
-
Review Comment:
This code is moved to RequestHandlerBase.normalizeReceivedException()
(currently, before this PR, the only caller), because it should not be here.
This method checks the "tragedy" status of the current index writer, it should
not modify the state. But this code replaces the index writer, making next call
to this method return always false because the "tragedy" state is reset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
